GH-138378: Move globals-to-consts pass into main optimizer pass#138379
Merged
markshannon merged 7 commits intopython:mainfrom Sep 18, 2025
Merged
Conversation
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Very nice improvement!
Include/internal/pycore_optimizer.h
Outdated
| // Max stacklen | ||
| int stack_len; | ||
| int locals_len; | ||
| uint32_t globals_checked_version; |
Member
There was a problem hiding this comment.
For consistency, this should be placed after the last few fields in the current struct and they should be commented. E.g. // globals to constant promotion.
Member
Author
There was a problem hiding this comment.
Fields should be in either ascending or descending order, for best packing, so I can't just add the fields at the end.
I'll add the comment.
Fidget-Spinner
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes #136154.